[PATCH] scsi: ufs: Convert all platform drivers to return void

Martin K. Petersen martin.petersen at oracle.com
Thu Sep 21 18:48:32 PDT 2023


Uwe,

> The .remove() callback for a platform driver returns an int which
> makes many driver authors wrongly assume it's possible to do error
> handling by returning an error code. However the value returned is
> ignored (apart from emitting a warning) and this typically results in
> resource leaks. To improve here there is a quest to make the remove
> callback return void. In the first step of this quest all drivers are
> converted to .remove_new() which already returns void. Eventually
> after all drivers are converted, .remove_new() is renamed to
> .remove().
>
> All platform drivers below drivers/ufs/ unconditionally return zero in
> their remove callback and so can be converted trivially to the variant
> returning void.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering



More information about the linux-arm-kernel mailing list