[PATCH 35/59] dma: qcom: hidma: Convert to platform remove callback returning void

Konrad Dybcio konrad.dybcio at linaro.org
Tue Sep 19 14:02:45 PDT 2023



On 9/19/23 15:31, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>

Konrad



More information about the linux-arm-kernel mailing list