[PATCH] mmc: atmel-mci: Remove preprocessor directive

Linus Walleij linus.walleij at linaro.org
Thu Sep 14 06:49:21 PDT 2023


On Thu, Sep 14, 2023 at 2:16 PM Ulf Hansson <ulf.hansson at linaro.org> wrote:
> On Tue, 29 Aug 2023 at 09:18, Linus Walleij <linus.walleij at linaro.org> wrote:
> >
> > On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
> > <balamanikandan.gunasundar at microchip.com> wrote:
> >
> > > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> > > checking if the device is compatible with atmel,hsmci. Instead handle it in
> > > the if() condition. The compiler optimizes out the entire if() clause if
> > > the first expression in the if() clause is constant false.
> > >
> > > Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar at microchip.com>
> > > Suggested-by: Linus Walleij <linus.walleij at linaro.org>
> >
> > Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> >
> > Thanks for tidying this up Balamanikandan!
>
> Linus, we didn't manage to get this into v6.6. So, it's probably
> better if you pick up this via your tree for v6.7.

Oh it's actually Bartosz managing the GPIO tree these days.
(Which I am very happy about!)

The best is to resend the patch to the GPIO maintainers and
linux-gpio at vger.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list