[PATCH v8 2/8] perf metric: "Compat" supports matching multiple identifiers
Jing Zhang
renyu.zj at linux.alibaba.com
Thu Sep 7 04:58:27 PDT 2023
The jevent "Compat" is used for uncore PMU alias or metric definitions.
The same PMU driver has different PMU identifiers due to different
hardware versions and types, but they may have some common PMU metric.
Since a Compat value can only match one identifier, when adding the
same metric to PMUs with different identifiers, each identifier needs
to be defined once, which is not streamlined enough.
So let "Compat" supports matching multiple identifiers for uncore PMU
metric.
Signed-off-by: Jing Zhang <renyu.zj at linux.alibaba.com>
Reviewed-by: John Garry <john.g.garry at oracle.com>
Reviewed-by: Ian Rogers <irogers at google.com>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 6231044..060ebe4c 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -498,7 +498,7 @@ static int metricgroup__sys_event_iter(const struct pmu_metric *pm,
while ((pmu = perf_pmus__scan(pmu))) {
- if (!pmu->id || strcmp(pmu->id, pm->compat))
+ if (!pmu->id || !pmu_uncore_identifier_match(pmu->id, pm->compat))
continue;
return d->fn(pm, table, d->data);
--
1.8.3.1
More information about the linux-arm-kernel
mailing list