[PATCH v3 1/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

Sean Young sean at mess.org
Wed Sep 6 09:03:25 PDT 2023


On Wed, Sep 06, 2023 at 05:58:03PM +0200, Uwe Kleine-König wrote:
> On Tue, Aug 22, 2023 at 03:56:43PM +0100, Sean Young wrote:
> > The ir-rx51 is a pwm-based TX driver specific to the N900. This can be
> > handled entirely by the generic pwm-ir-tx driver, and in fact the
> > pwm-ir-tx driver has been compatible with ir-rx51 from the start.
> > 
> > Note that the suspend code in the ir-rx51 driver is unnecessary, since
> > during transmit, the process is not in interruptable sleep. The process
> > is not put to sleep until the transmit completes.
> > 
> > Tested-by: Sicelo A. Mhlongo <absicsz at gmail.com>
> > Signed-off-by: Sean Young <sean at mess.org>
> > Cc: Tony Lindgren <tony at atomide.com>
> > Cc: Russell King <linux at armlinux.org.uk>
> > Cc: Thierry Reding <thierry.reding at gmail.com>
> > Cc: "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de>
> > Cc: linux-omap at vger.kernel.org
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-pwm at vger.kernel.org
> > Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75 at gmail.com>
> > Cc: Pali Rohár <pali.rohar at gmail.com>
> > Cc: Pavel Machek <pavel at ucw.cz>
> > Cc: Timo Kokkonen <timo.t.kokkonen at iki.fi>
> 
> Looks ok for me. I assume this will go in via the media tree and the pwm
> list was only Cc:d because drivers/media/rc/pwm-ir-tx.c uses pwm
> functions?

That is exactly right.

> I'll mark this patch as "handled-elsewhere" in the pwm
> patchwork. Please tell me if you object.
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

That's perfect.

Thanks,

Sean



More information about the linux-arm-kernel mailing list