[PATCH v2 6/6] regulator: bcm590xx: Add proper handling for PMMODE registers

Mark Brown broonie at kernel.org
Tue Oct 31 05:53:14 PDT 2023


On Mon, Oct 30, 2023 at 08:41:48PM +0100, Artur Weber wrote:

> +	for (i = 0; i < pmctrl_count; i++) {
> +		ret = regmap_write(regmap, pmctrl_addr + i, mode_mask);
> +		if (ret)
> +			return ret;
> +	}

Why not a bulk write?  What happens when the new values are partially
written, both if there's an error and just transiently?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20231031/3a0f3946/attachment.sig>


More information about the linux-arm-kernel mailing list