[PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards

[Krzysztof Kozlowski]

On 29/10/2023 18:48, Elad Nachman wrote:
> From: Elad Nachman <enachman at marvell.com>
> 

A nit, subject: drop second/last, redundant "dt-bindings for". The
"dt-bindings" prefix is already stating that these are bindings.

> Add dt bindings for:
> CN9130 COM Express CPU module
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
> 
> Signed-off-by: Elad Nachman <enachman at marvell.com>
> ---
>  .../bindings/arm/marvell/armada-7k-8k.yaml        | 15 +++++++++++++++
>  .../bindings/arm/marvell/marvell,ac5.yaml         | 14 ++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 52d78521e412..7e0ac5110eef 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -60,4 +60,19 @@ properties:
>            - const: marvell,armada-ap807-quad
>            - const: marvell,armada-ap807
>  
> +      - description: Armada CN9130 SoC without external CP as COM Express CPU module
> +        items:
> +          - const: marvell,cn9130-cpu-module

How CPU module can be used alone?

> +          - const: marvell,cn9130
> +          - const: marvell,armada-ap807-quad
> +          - const: marvell,armada-ap807
> +
> +      - description: Armada CN9131 SoC with one external CP as COM Express CPU module
> +        items:
> +          - const: marvell,cn9131-cpu-module
> +          - const: marvell,cn9131
> +          - const: marvell,cn9130
> +          - const: marvell,armada-ap807-quad
> +          - const: marvell,armada-ap807
> +
>  additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> index 8960fb8b2b2f..734e1716a3e9 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> @@ -27,6 +27,20 @@ properties:
>            - const: marvell,ac5x
>            - const: marvell,ac5
>  
> +      - description: Alleycat5X (98DX35xx) Reference Design as COM Express Carrier
> +        items:
> +          - enum:
> +              - marvell,rd-ac5x-carrier
> +          - const: marvell,ac5x
> +
> +      - description:
> +           Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus
> +           Armada CN9131 COM Express CPU module
> +        items:
> +          - enum:
> +              - marvell,rd-ac5x-carrier-with-cn9131
> +          - const: marvell,ac5x

You never responded to me concerns, so I still do not know what's this.
This claims it has CN9131, but compatibles are missing.

Can anyone help us understand why AC5 has CN9130 but these are in
different files?

Best regards,
Krzysztof