[PATCH] pmdomain: imx: Make imx pgc power domain also set the fwnode
Emil Kronborg Andersen
emkan at prevas.dk
Thu Oct 26 00:53:56 PDT 2023
On Sat, Oct 21, 2023 at 02:59 +0800, Pengfei Li wrote:
> Currently, The imx pgc power domain doesn't set the fwnode
> pointer, which results in supply regulator device can't get
> consumer imx pgc power domain device from fwnode when creating
> a link.
>
> This causes the driver core to instead try to create a link
> between the parent gpc device of imx pgc power domain device and
> supply regulator device. However, at this point, the gpc device
> has already been bound, and the link creation will fail. So adding
> the fwnode pointer to the imx pgc power domain device will fix
> this issue.
>
> Signed-off-by: Pengfei Li <pengfei.li_1 at nxp.com>
> ---
> drivers/pmdomain/imx/gpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/imx/gpc.c b/drivers/pmdomain/imx/gpc.c
> index 114f44ca07dd..7d81e3171d39 100644
> --- a/drivers/pmdomain/imx/gpc.c
> +++ b/drivers/pmdomain/imx/gpc.c
> @@ -497,6 +497,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
>
> pd_pdev->dev.parent = &pdev->dev;
> pd_pdev->dev.of_node = np;
> + pd_pdev->dev.fwnode = of_fwnode_handle(np);
>
> ret = platform_device_add(pd_pdev);
> if (ret) {
> --
> 2.34.1
I originally proposed [1] to address errors like the one below:
[ 1.039830] imx-gpc 20dc000.gpc: Failed to create device link (0x180) with 20c8000.anatop:regulator-vddpu
I tested this patch on an i.MX 6Quad board, and it also fixes these
errors.
Tested-by: Emil Kronborg <emil.kronborg at protonmail.com>
[1]
https://lore.kernel.org/linux-arm-kernel/20231012132214.257207-1-emkan@prevas.dk/T/
Best regards,
Emil
More information about the linux-arm-kernel
mailing list