[PATCH net-next v7 5/7] ARM64: dts: marvell: Fix some common switch mistakes
Vladimir Oltean
olteanv at gmail.com
Tue Oct 24 13:20:09 PDT 2023
Hello Chris,
On Tue, Oct 24, 2023 at 08:10:14PM +0000, Chris Packham wrote:
> > Chris, does this look okay?
>
> There's nothing in the u-boot code for the CN9130-CRB that cares about
> the switch so I don't think there's any issue ABI wise. We are working
> on our own CN9130 based router with a L2 switch but it's at a point we
> can follow whatever upstream decide is the final schema.
Thank you for taking the time to confirm.
> In terms of my personal preference the schema quoted up thread has the
> pattern '^(ethernet-)?switch(@.*)?$' (i.e. the 'ethernet-' part is
> optional) so I'd personally prefer switch0 at 6 -> switch at 6 but that's only
> a slight preference because I deal with Ethernet switches day in day out.
The movement originally came from "ports" to "ethernet-ports" at Rob's
suggestion, because of the name clash with the ports from graph.yaml.
Then we also did "switch" -> "ethernet-switch" because you'll also find
"pcie-switch" in mainline device trees.
More information about the linux-arm-kernel
mailing list