[PATCH 09/19] iommu/arm-smmu-v3: Hold arm_smmu_asid_lock during all of attach_dev

Jason Gunthorpe jgg at nvidia.com
Tue Oct 24 04:50:24 PDT 2023


On Tue, Oct 24, 2023 at 10:44:36AM +0800, Michael Shavit wrote:

> > @@ -2549,7 +2547,17 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
> >
> >         mutex_unlock(&smmu_domain->init_mutex);
> >         if (ret)
> > -               return ret;
> > +               goto out_unlock;
> 
> Oh, missed this earlier but on a second look the asid_lock isn't
> grabbed here yet so this should stay as return ret.

Yep, there is a hunk in a later patch fixing this, I moved it here

Thanks,
Jason



More information about the linux-arm-kernel mailing list