[PATCH v4 06/12] KVM: arm64: Use LPA2 page-tables for stage2 and hyp stage1

Marc Zyngier maz at kernel.org
Mon Oct 23 02:36:32 PDT 2023


On Fri, 20 Oct 2023 16:06:50 +0100,
Ryan Roberts <ryan.roberts at arm.com> wrote:
> 
> On 20/10/2023 10:16, Marc Zyngier wrote:
> > On Mon, 09 Oct 2023 19:50:02 +0100,
> > Ryan Roberts <ryan.roberts at arm.com> wrote:
> >>
> >> diff --git a/arch/arm64/kvm/hyp/nvhe/tlb.c b/arch/arm64/kvm/hyp/nvhe/tlb.c
> >> index d42b72f78a9b..c3cd16c6f95f 100644
> >> --- a/arch/arm64/kvm/hyp/nvhe/tlb.c
> >> +++ b/arch/arm64/kvm/hyp/nvhe/tlb.c
> >> @@ -198,7 +198,8 @@ void __kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu,
> >>  	/* Switch to requested VMID */
> >>  	__tlb_switch_to_guest(mmu, &cxt, false);
> >>  
> >> -	__flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0, false);
> >> +	__flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0,
> >> +				system_supports_lpa2());
> > 
> > At this stage, I'd fully expect the flag to have been subsumed into
> > the helper...
> 
> ACK. I'm planning to have has_lpa2() always return false for now. Then once
> Ard's changes are in, we can change it to report the system status. Then we can
> move this inside __flush_s2_tlb_range_op(). Does that work for you?

Sure, go for it and see what it looks like.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list