[PATCH v4 01/12] arm64/mm: Update non-range tlb invalidation routines for FEAT_LPA2

Marc Zyngier maz at kernel.org
Fri Oct 20 06:02:22 PDT 2023


On Fri, 20 Oct 2023 13:39:47 +0100,
Ryan Roberts <ryan.roberts at arm.com> wrote:
> 
> On 20/10/2023 09:05, Marc Zyngier wrote:
> > Maybe. There is something to be said about making the range rework
> > (decreasing scale) an independent patch, as it is a significant change
> > on its own. But maybe the rest of the plumbing can be grouped
> > together.
> 
> But that's effectively the split I have now, isn't it? The first patch
> introduces TLBI_TTL_UNKNOWN to enable use of 0 as a ttl hint. Then the second
> patch reworks the range stuff. I don't quite follow what you are suggesting.

Not quite.

What I'm proposing is that you pull the scale changes in their own
patch, and preferably without any change to the external API (i.e. no
change to the signature of the helper). They any extra change, such as
the TTL rework can go separately.

So while this is similar to your existing split, I'd like to see it
without any churn around the calling convention. Which means turning
the ordering around, and making use of a static key in the various
helpers that need to know about LPA2.

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list