[PATCH net-next v4 3/7] ARM: dts: marvell: Fix some common switch mistakes
Vladimir Oltean
olteanv at gmail.com
Thu Oct 19 07:29:59 PDT 2023
On Thu, Oct 19, 2023 at 12:04:46PM +0100, Russell King (Oracle) wrote:
> On Wed, Oct 18, 2023 at 11:03:42AM +0200, Linus Walleij wrote:
> > Fix some errors in the Marvell MV88E6xxx switch descriptions:
> > - The top node had no address size or cells.
> > - switch0 at 0 is not OK, should be switch at 0.
> > - The ports node should have port at 0 etc children, no
> > plural "ports".
> >
> > This serves as an example of fixes needed for introducing a
> > schema for the bindings, but the patch can simply be applied.
>
> In patch 2, you mention that things should be named ethernet-switch and
> ethernet-port. As you're renaming the nodes in this patch, wouldn't it
> make sense to use those names instead now, rather than at some point in
> the future a patch that converts to these names?
I agree, and I was wondering the same thing.
More information about the linux-arm-kernel
mailing list