[PATCH] coresight: etm4x: Remove bogous __exit annotation for some functions

Suzuki K Poulose suzuki.poulose at arm.com
Mon Oct 16 16:08:25 PDT 2023


On 02/10/2023 10:44, Suzuki K Poulose wrote:
> On 29/09/2023 09:16, Uwe Kleine-König wrote:
>> etm4_platform_driver (which lives in ".data" contains a reference to
>> etm4_remove_platform_dev(). So the latter must not be marked with __exit
>> which results in the function being discarded for a build with
>> CONFIG_CORESIGHT_SOURCE_ETM4X=y which in turn makes the remove pointer
>> contain invalid data.
>>
>> etm4x_amba_driver referencing etm4_remove_amba() has the same issue.
>>
>> Drop the __exit annotations for the two affected functions and a third
>> one that is called by the other two.
>>
>> For reasons I don't understand this isn't catched by building with
>> CONFIG_DEBUG_SECTION_MISMATCH=y.
>>
>> Fixes: c23bc382ef0e ("coresight: etm4x: Refactor probing routine")
>> Fixes: 5214b563588e ("coresight: etm4x: Add support for sysreg only 
>> devices")
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> Thanks for the fix, I can queue them via the coresight tree.

I have queued this for next:

	https://git.kernel.org/coresight/c/aca46e6f0350

Suzuki

> 
> Suzuki
> 
> 
> _______________________________________________
> CoreSight mailing list -- coresight at lists.linaro.org
> To unsubscribe send an email to coresight-leave at lists.linaro.org




More information about the linux-arm-kernel mailing list