[PATCH 00/27] Update SMMUv3 to the modern iommu API (part 2/2)
Jason Gunthorpe
jgg at nvidia.com
Wed Oct 11 16:25:36 PDT 2023
Continuing the work of part 1 this focuses on the CD, PASID and SVA
components:
- attach_dev failure does not change the HW configuration.
- Full PASID API support including:
- S1/SVA domains attached to PASIDs
- IDENTITY/BLOCKED/S1 attached to RID
- Change of the RID domain while PASIDs are attached
- Streamlined SVA support using the core infrastructure
- Hitless, whenever possible, change between two domains
Making the CD programming work like the new STE programming allows
untangling some of the confusing SVA flows. From there the focus is on
building out the core infrastructure for dealing with PASID and CD
entries, then keeping track of unique SSID's for ATS invalidation.
The ATS ordering is generalized so that the PASID flow can use it and put
into a form where it is fully hitless, whenever possible.
Finally we simply kill the entire outdated SVA mmu_notifier implementation
in one shot and switch it over to the newly created generic PASID & CD
code. This avoids the messy and confusing approach of trying to
incrementally untangle this in place. The new code is small and simple
enough this is much better than trying to figure out fixes.
Once SVA is resting on the right CD code it is straightforward to make the
PASID interface functionally complete.
This depends on part 1
The SVA change requires Tina's series:
https://lore.kernel.org/linux-iommu/20230925023813.575016-1-tina.zhang@intel.com/
(Although if you have only a single SVA device it is not necessary to
test)
It achives the same goals as the several series from Michael and the S1DSS
series from Nicolin that were trying to improve portions of the API.
There are still topics for a part 3 (as yet unwritten) which would want to
make iommu_domains work across instances, split the s1/2 domain ops, and
further polish some of the code.
This is on github: https://github.com/jgunthorpe/linux/commits/smmuv3_newapi
Jason Gunthorpe (27):
iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA
iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong
PASID
iommu/arm-smmu-v3: Do not ATC invalidate the entire domain
iommu/arm-smmu-v3: Add a type for the CD entry
iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry_step()
iommu/arm-smmu-v3: Consolidate clearing a CD table entry
iommu/arm-smmu-v3: Move the CD generation for S1 domains into a
function
iommu/arm-smmu-v3: Move allocation of the cdtable into
arm_smmu_get_cd_ptr()
iommu/arm-smmu-v3: Allocate the CD table entry in advance
iommu/arm-smmu-v3: Move the CD generation for SVA into a function
iommu/arm-smmu-v3: Lift CD programming out of the SVA notifier code
iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd()
iommu/arm-smmu-v3: Make smmu_domain->devices into an allocated list
iommu/arm-smmu-v3: Make changing domains be hitless for ATS
iommu/arm-smmu-v3: Add ssid to struct arm_smmu_master_domain
iommu/arm-smmu-v3: Keep track of valid CD entries in the cd_table
iommu/arm-smmu-v3: Thread SSID through the arm_smmu_attach_*()
interface
iommu/arm-smmu-v3: Make SVA allocate a normal arm_smmu_domain
iommu/arm-smmu-v3: Keep track of arm_smmu_master_domain for SVA
iommu: Add ops->domain_alloc_sva()
iommu/arm-smmu-v3: Put the SVA mmu notifier in the smmu_domain
iommu/arm-smmu-v3: Consolidate freeing the ASID/VMID
iommu/arm-smmu-v3: Move the arm_smmu_asid_xa to per-smmu like vmid
iommu/arm-smmu-v3: Bring back SVA BTM support
iommu/arm-smmu-v3: Allow IDENTITY/BLOCKED to be set while PASID is
used
iommu/arm-smmu-v3: Allow a PASID to be set when RID is
IDENTITY/BLOCKED
iommu/arm-smmu-v3: Allow setting a S1 domain to a PASID
.../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 620 ++++++-------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 846 ++++++++++++------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 94 +-
drivers/iommu/iommu-sva.c | 4 +-
drivers/iommu/iommu.c | 12 +-
include/linux/iommu.h | 3 +
6 files changed, 888 insertions(+), 691 deletions(-)
base-commit: 0f6f4b2cc77710aef8d0734a27206f1e1e9a360d
--
2.42.0
More information about the linux-arm-kernel
mailing list