[PATCH v2 1/5] tools headers arm64: Copy sysreg-defs generation from kernel source

[Oliver Upton]

On Wed, Oct 11, 2023 at 05:59:28PM +0100, Mark Brown wrote:
> On Wed, Oct 11, 2023 at 05:51:57PM +0100, Marc Zyngier wrote:
> > Oliver Upton <oliver.upton at linux.dev> wrote:
> 
> > > The system register definitions are now generated with a script over in
> > > the kernel sources. Pull a copy into tools in anticipation of updating
> > > dependent header files and add a common makefile for generating the
> > > header.
> 
> > Rather than a copy, which makes the maintenance pretty horrible, why
> > don't you just symlink it? Git is perfectly capable of storing them,
> > last time I checked.
> 
> Do we even need to symlink - as I suggested on the previous version can
> we not just reference the script and data file directly in the main
> kernel tree?  Like I said then there may be some use case for building
> the tools directory outside the kernel source that I'm not aware of but
> otherwise I'm not clear that the motivations for copying the actual
> headers for use in tools/ apply to these files.
> 
> I think the current approach is *fine* (hence my reviewed by) 
> given the amount of other copying but it would save a bit of work to not
> copy.

So long as we aren't going to do any further renames I don't have an
issue with this approach.

-- 
Thanks,
Oliver