[PATCH 04/11] pwm: brcmstb: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions

[Uwe Kleine-König]

On Wed, Oct 11, 2023 at 12:21:52PM +0100, Jonathan Cameron wrote:
> On Tue, 10 Oct 2023 09:51:05 +0200
> Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
> 
> > This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
> > care about when the functions are actually used, so the corresponding
> > #ifdef can be dropped.
> > 
> > Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
> > isn't enabled.
> 
> The additional change to potentially return an error when not doing so before
> wants to be called out in the description.

Indeed, good catch. Something like:

	pwm: brcmstb: Use DEFINE_SIMPLE_DEV_PM_OPS for PM

	This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
	care about when the functions are actually used, so the corresponding
	#ifdef can be dropped.

	Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
	isn't enabled.

	While touching brcmstb_pwm_suspend() also propagate the return
	value of clk_enable() to the caller of .suspend().

	Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

I fixed that in my tree, so if and when v2 happens, this comment will be
addressed.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20231011/db8090d4/attachment.sig>