[PATCH v2 17/20] arm64: dts: google: Add initial Google gs101 SoC support

Greg KH gregkh at linuxfoundation.org
Wed Oct 11 00:50:12 PDT 2023


On Tue, Oct 10, 2023 at 11:49:25PM +0100, Peter Griffin wrote:
> +		serial_0: serial at 10a00000 {
> +			compatible = "google,gs101-uart";

You use this entry, but:

> +			reg = <0x0 0x10a00000 0xc0>;
> +			reg-io-width = <4>;
> +			samsung,uart-fifosize = <256>;

See, it's really the samsung IP block.  Please don't declare new
compatible entries when you don't need to, it just adds churn to the
kernel for no reason (and makes you do more work.)

thanks,

greg k-h



More information about the linux-arm-kernel mailing list