[PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support

Pandey, Radhey Shyam radhey.shyam.pandey at amd.com
Fri Oct 6 11:24:17 PDT 2023


> -----Original Message-----
> From: Jakub Kicinski <kuba at kernel.org>
> Sent: Thursday, October 5, 2023 2:11 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey at amd.com>
> Cc: davem at davemloft.net; edumazet at google.com; pabeni at redhat.com;
> robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org;
> conor+dt at kernel.org; Simek, Michal <michal.simek at amd.com>;
> linux at armlinux.org.uk; f.fainelli at gmail.com; netdev at vger.kernel.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; git (AMD-Xilinx) <git at amd.com>; Sarath Babu
> Naidu Gaddam <sarath.babu.naidu.gaddam at amd.com>
> Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
> dmaengine support
> 
> On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:
> >   */
> > -static int axienet_open(struct net_device *ndev)
> > +
> 
> nit: spurious new line
> 
> > +static inline int axienet_init_legacy_dma(struct net_device *ndev)
> 
> nit: no need for the inline, it has one caller and isn't on the fast path
Thanks, will fix both in next version.



More information about the linux-arm-kernel mailing list