[PATCH V2 1/2] leds: gpio: Add kernel log if devm_fwnode_gpiod_get fails

Linus Walleij linus.walleij at linaro.org
Wed Nov 29 06:03:04 PST 2023


On Wed, Nov 22, 2023 at 11:53 AM Bartosz Golaszewski <brgl at bgdev.pl> wrote:

> > > I cannot remember that i saw any of them on info level in my case of an
> > > already allocated pin (see patch 2).
> > >
> > > I'm open to place the log within gpiolib, if this a better place.
> >
> > I'm not sure, let's hear GPIO maintainers for that.
>
> Hard to tell which method is preferred among all the subsystems.
> Personally I'm more inclined towards letting drivers decide whether to
> emit an error message and only emit our own when an error cannot be
> propagated down the stack.
>
> Linus: Any thoughts?

I never managed to get it right so I can't give any good advice.

Usually I tend to think better one more error message than one too little.

Then again I'm a dmesg maximalist who just want it to scroll on forever
also with positive messages...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list