[PATCH v6 17/41] arm64: idreg-override: avoid strlen() to check for empty strings
Ard Biesheuvel
ardb at google.com
Wed Nov 29 03:16:13 PST 2023
From: Ard Biesheuvel <ardb at kernel.org>
strlen() is a costly way to decide whether a string is empty, as in that
case, the first character will be NUL so we can check for that directly.
Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
---
arch/arm64/kernel/idreg-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c
index 1eca93446345..8b22ca523186 100644
--- a/arch/arm64/kernel/idreg-override.c
+++ b/arch/arm64/kernel/idreg-override.c
@@ -232,7 +232,7 @@ static void __init match_options(const char *cmdline)
override = prel64_pointer(reg->override);
- for (f = 0; strlen(reg->fields[f].name); f++) {
+ for (f = 0; reg->fields[f].name[0] != '\0'; f++) {
u64 shift = reg->fields[f].shift;
u64 width = reg->fields[f].width ?: 4;
u64 mask = GENMASK_ULL(shift + width - 1, shift);
--
2.43.0.rc1.413.gea7ed67945-goog
More information about the linux-arm-kernel
mailing list