[PATCH v2 0/2] staging: vc04_services: Use %p to log pointer
Umang Jain
umang.jain at ideasonboard.com
Tue Nov 28 12:20:05 PST 2023
%lx is used to print the unmodified pointer address for debugging.
%p will print the hashed pointer address to avoid leaking information
about kernel memory layout to userspace. But when `no_hash_pointers`
is passed as kernel parameter, unmodified pointer address will be
printed.
Hence, drop %lx in favour of %p. For debugging purposes, one can
easily depend on `no_hash_pointers`.
This also solves the following smatch warnings:
service_callback() warn: argument 7 to %lx specifier is cast from pointer
service_callback() warn: argument 11 to %lx specifier is cast from pointer
service_callback() warn: argument 12 to %lx specifier is cast from pointer
service_callback() warn: argument 13 to %lx specifier is cast from pointer
vchiq_release() warn: argument 7 to %lx specifier is cast from pointer
Changes in v2:
- Built/Rebased on top of:
[PATCH v2 0/5] staging: vc04_services: Drop custom logging
Umang Jain (2):
staging: vc04_services: Use %p to log pointer address
staging: vc04_services: Use %p to log pointer address
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +++----
.../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
--
2.41.0
More information about the linux-arm-kernel
mailing list