[PATCH v2] drm/mxsfb: Switch to drmm_mode_config_init

[Thomas Zimmermann]

Hi

Am 28.11.23 um 09:27 schrieb Maxime Ripard:
> Hi,
> 
> On Mon, Nov 27, 2023 at 10:25:38PM +0100, Marek Vasut wrote:
>> Switch from deprecated unmanaged drm_mode_config_init() to
>> managed drmm_mode_config_init(). No functional change.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> ---
>> Cc: Daniel Vetter <daniel at ffwll.ch>
>> Cc: David Airlie <airlied at gmail.com>
>> Cc: Fabio Estevam <festevam at gmail.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Cc: Maxime Ripard <mripard at kernel.org>
>> Cc: NXP Linux Team <linux-imx at nxp.com>
>> Cc: Pengutronix Kernel Team <kernel at pengutronix.de>
>> Cc: Sascha Hauer <s.hauer at pengutronix.de>
>> Cc: Shawn Guo <shawnguo at kernel.org>
>> Cc: Stefan Agner <stefan at agner.ch>
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: dri-devel at lists.freedesktop.org
>> Cc: linux-arm-kernel at lists.infradead.org
> 
> This is only somewhat related to that patch, but mksfb_drm_private is
> allocated with devm and holds the planes, crtcs and encoders. This is
> unsafe, leads to UAF, and should be converted to a drmm allocation too
> (in another patch of course)

To add to this, the whole driver's probe/remove should be converted to 
managed code. There's irq and pm code that could likely be updated. 
Marek, if you have the means, patches are welcome.

Best regards
Thomas

> 
> Maxime

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20231128/9a63774e/attachment-0001.sig>