[RESEND PATCH v7 09/10] selftests/mm/cow: Generalize do_run_with_thp() helper
David Hildenbrand
david at redhat.com
Mon Nov 27 05:59:36 PST 2023
>>
>>> + pmdsize = read_pmd_pagesize();
>>> + if (pmdsize)
>>> + ksft_print_msg("[INFO] detected PMD-mapped THP size: %zu KiB\n",
>>
>> Maybe simply: "detected PMD size". Zes, we read it via the THP interface, but
>> that shouldn't matter much.
>
> Err, just want to clarify what you are suggesting. With the current patch you
> will see something like:
Not with this patch, but with the other ones, yes :)
>
> [INFO] detected PMD-mapped THP size: 2048 KiB
> [INFO] detected small-sized THP size: 64 KiB
> [INFO] detected small-sized THP size: 128 KiB
> ...
> [INFO] detected small-sized THP size: 1024 KiB
>
>
> Are you suggesting something like this:
>
> [INFO] detected PMD size: 2048 KiB
> [INFO] detected THP size: 64 KiB
> [INFO] detected THP size: 128 KiB
> ...
> [INFO] detected THP size: 2048 KiB
>
Yes. If you'd detect that 2M is actually disabled, you could still log
the PMD size only.
So for this patch only as a preparation
[INFO] detected PMD size: 2048 KiB
[INFO] detected THP size: 2048 KiB
Just a thought.
--
Cheers,
David / dhildenb
More information about the linux-arm-kernel
mailing list