[PATCH 9/9] pmdomain: xilinx/zynqmp: Convert to platform remove callback returning void

[Michal Simek]

On 11/24/23 09:06, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/pmdomain/xilinx/zynqmp-pm-domains.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pmdomain/xilinx/zynqmp-pm-domains.c b/drivers/pmdomain/xilinx/zynqmp-pm-domains.c
> index 69d03ad4cf1e..6fd514286d82 100644
> --- a/drivers/pmdomain/xilinx/zynqmp-pm-domains.c
> +++ b/drivers/pmdomain/xilinx/zynqmp-pm-domains.c
> @@ -293,11 +293,9 @@ static int zynqmp_gpd_probe(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int zynqmp_gpd_remove(struct platform_device *pdev)
> +static void zynqmp_gpd_remove(struct platform_device *pdev)
>   {
>   	of_genpd_del_provider(pdev->dev.parent->of_node);
> -
> -	return 0;
>   }
>   
>   static void zynqmp_gpd_sync_state(struct device *dev)
> @@ -315,7 +313,7 @@ static struct platform_driver zynqmp_power_domain_driver = {
>   		.sync_state = zynqmp_gpd_sync_state,
>   	},
>   	.probe = zynqmp_gpd_probe,
> -	.remove = zynqmp_gpd_remove,
> +	.remove_new = zynqmp_gpd_remove,
>   };
>   module_platform_driver(zynqmp_power_domain_driver);
>   

Acked-by: Michal Simek <michal.simek at amd.com>

Thanks,
Michal