> +const char *sfp_get_name(struct sfp_bus *bus) > +{ > + if (bus->sfp_dev) > + return dev_name(bus->sfp_dev); > + > + return NULL; > +} Locking? Do you assume rtnl? Does this function need to take rtnl? Andrew