[PATCH v10 0/5] drivers/perf: add Synopsys DesignWare PCIe PMU driver support
Ilkka Koskinen
ilkka at os.amperecomputing.com
Wed Nov 15 16:57:00 PST 2023
Hi Shuai,
On Sat, 4 Nov 2023, Shuai Xue wrote:
> Change Log
> ==========
>
> - move the &plat_dev->dev to previous line to warp more beautiful (Per Jonathan)
> - rename error label with the same suffix 'err' (Per Jonathan)
> - drop unnecessary else branch and return directly (Per Baolin)
> - warp out set prev_count from dwc_pcie_pmu_set_period (Per Baolin)
> - use PMU_FORMAT_ATTR to simplify format sysfs stuff (Per Will)
> - export pci_clear_and_set_dword() to simplify _enable() functions (Per Will)
> - simplify _read() function by unconditionally calculate with unit in bytes plused if branch for group#1 event (Per Will and Robin)
> - simplify _update() function by unconditionally mask with 64-bit width plused if branch for lane event (Per Will)
> - add type sanity check in _init() (Per Will)
> - test with fuzzing tool before this new version (Per Will)
> - register a platform device for each PCI device to probe RAS_DES PMU cap (Per Robin)
> - add dwc_pcie_vendor_ids to extend vendor id for future added device (Per Krishna)
> - pickup review-by tag from Baolin, Yicong and Jonathan
...
> Shuai Xue (5):
> docs: perf: Add description for Synopsys DesignWare PCIe PMU driver
> PCI: Add Alibaba Vendor ID to linux/pci_ids.h
> PCI: move pci_clear_and_set_dword helper to pci header
> drivers/perf: add DesignWare PCIe PMU driver
> MAINTAINERS: add maintainers for DesignWare PCIe PMU driver
As I mentioned earlier, I successfully tested your patchset with a few
patches on top of it to enable DWC PCIe PMU on AmpereOne. Thus, feel free
to add this tag to all the patches above:
Tested-by: Ilkka Koskinen <ilkka at os.amperecomputing.com>
Br, Ilkka
>
> .../admin-guide/perf/dwc_pcie_pmu.rst | 94 +++
> Documentation/admin-guide/perf/index.rst | 1 +
> MAINTAINERS | 7 +
> drivers/infiniband/hw/erdma/erdma_hw.h | 2 -
> drivers/pci/access.c | 12 +
> drivers/pci/pcie/aspm.c | 11 -
> drivers/perf/Kconfig | 7 +
> drivers/perf/Makefile | 1 +
> drivers/perf/dwc_pcie_pmu.c | 798 ++++++++++++++++++
> include/linux/pci.h | 2 +
> include/linux/pci_ids.h | 2 +
> 11 files changed, 924 insertions(+), 13 deletions(-)
> create mode 100644 Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> create mode 100644 drivers/perf/dwc_pcie_pmu.c
>
> --
> 2.39.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
More information about the linux-arm-kernel
mailing list