> >>> +/* ---- Private Variables ----------------------------------------------- */ >>> + >>> +static struct sm_state_t *sm_state; >>> +static int sm_inited; >> >> In case the driver cannot be loaded again, a comment about this should >> be here. > > Better, could we remove global variables ? Yes > > [snip] >