[PATCH 34/52] serial: samsung: Convert to platform remove callback returning void

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Sat Nov 11 23:48:49 PST 2023


On 10/11/2023 16:30, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

Maybe let's trim the commit msg? Or convert all drivers at once if you
want to drop long explanation...

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list