[PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied at gmail.com>; Daniel Vetter <daniel at ffwll.ch>;
> Maarten Lankhorst <maarten.lankhorst at linux.intel.com>; Maxime Ripard
> <mripard at kernel.org>; Thomas Zimmermann <tzimmermann at suse.de>;
> Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley
> <conor+dt at kernel.org>; Alim Akhtar <alim.akhtar at samsung.com>; Andi
> Shyti <andi.shyti at kernel.org>; Jonathan Cameron <jic23 at kernel.org>; Lars-
> Peter Clausen <lars at metafoo.de>; Lee Jones <lee at kernel.org>; Ulf
> Hansson <ulf.hansson at linaro.org>; Tomasz Figa <tomasz.figa at gmail.com>;
> Sylwester Nawrocki <s.nawrocki at samsung.com>; Linus Walleij
> <linus.walleij at linaro.org>; Thierry Reding <thierry.reding at gmail.com>; Uwe
> Kleine-König <u.kleine-koenig at pengutronix.de>; Alessandro Zummo
> <a.zummo at towertech.it>; Alexandre Belloni
> <alexandre.belloni at bootlin.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; Jiri Slaby <jirislaby at kernel.org>; Liam
> Girdwood <lgirdwood at gmail.com>; Mark Brown <broonie at kernel.org>;
> Jaehoon Chung <jh80.chung at samsung.com>; Sam Protsenko
> <semen.protsenko at linaro.org>; dri-devel at lists.freedesktop.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.org; linux-
> i2c at vger.kernel.org; linux-iio at vger.kernel.org; linux-mmc at vger.kernel.org;
> linux-gpio at vger.kernel.org; linux-pwm at vger.kernel.org; linux-
> rtc at vger.kernel.org; linux-serial at vger.kernel.org; alsa-devel at alsa-
> project.org; linux-sound at vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add
> specific compatibles for existing SoC
> 
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> 
Reviewed-by: Alim Akhtar <alim.akhtar at samsung.com>

> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
>  .../bindings/hwinfo/samsung,exynos-chipid.yaml  | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index 95cbdcb56efe..45f3d468db7c 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yam
> +++ l
> @@ -11,9 +11,20 @@ maintainers:
> 
>  properties:
>    compatible:
> -    enum:
> -      - samsung,exynos4210-chipid
> -      - samsung,exynos850-chipid
> +    oneOf:
> +      - enum:
> +          - samsung,exynos4210-chipid
> +          - samsung,exynos850-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos5433-chipid
> +              - samsung,exynos7-chipid
> +          - const: samsung,exynos4210-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos7885-chipid
> +              - samsung,exynosautov9-chipid
> +          - const: samsung,exynos850-chipid
> 
>    reg:
>      maxItems: 1
> --
> 2.34.1