[PATCH net-next 1/1] net: stmmac: Add support for HW-accelerated VLAN stripping

Andrew Lunn andrew at lunn.ch
Thu Nov 9 08:17:14 PST 2023


> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> @@ -198,6 +198,17 @@ static int dwmac4_get_tx_ls(struct dma_desc *p)
>  		>> TDES3_LAST_DESCRIPTOR_SHIFT;
>  }
>  
> +static inline int dwmac4_wrback_get_rx_vlan_tci(struct dma_desc *p)
> +{
> +	return (le32_to_cpu(p->des0) & RDES0_VLAN_TAG_MASK);
> +}
> +
> +static inline bool dwmac4_wrback_get_rx_vlan_valid(struct dma_desc *p)
> +{
> +	return ((le32_to_cpu(p->des3) & RDES3_LAST_DESCRIPTOR) &&
> +		(le32_to_cpu(p->des3) & RDES3_RDES0_VALID));
> +}

No inline functions in C files please. Let the compiler decide.

You are submitting a number of patches for this driver. Do they all
cleanly apply independent of each other? Or are there dependencies?

	Andrew



More information about the linux-arm-kernel mailing list