[PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume()

[Uwe Kleine-König]

Hello Thierry,

On Wed, Oct 25, 2023 at 02:11:03PM +0200, Uwe Kleine-König wrote:
> On Wed, Oct 25, 2023 at 02:57:34PM +0300, Dan Carpenter wrote:
> > The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
> > used as in a bitwise AND.  In this specific code the flag will never be
> > set so the function is effectively a no-op.
> > 
> > Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
> > Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> @Thierry: e3fe982b2e4e is currently in your for-next branch. So it would
> be good to get Dan's patch into your PR for 6.7-rc1.

I saw you updated your for-next branch but didn't add this patch yet.
Would be great to get this one in to not get a known-broken state into
6.7-rc1.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20231106/19a968ac/attachment-0001.sig>