[arm:cex7 76/79] drivers/net/phy/qsfp.c:1229:3: warning: misleading indentation; statement is not part of the previous 'if'

kernel test robot lkp at intel.com
Sun Nov 5 03:41:36 PST 2023


tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head:   279d4f83510a7ff8fc1b449ff43195057e5429dd
commit: b7915b5f9ae73b600c44ce96346a0c246ea28ae3 [76/79] net: add qsfp support                              [*experimental*]
config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231105/202311051950.gd99Mrfa-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051950.gd99Mrfa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311051950.gd99Mrfa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/phy/qsfp.c:1229:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
    1229 |                 qsfp_sm_ins_next(qsfp, SFP_MOD_PRESENT, 0);
         |                 ^
   drivers/net/phy/qsfp.c:1222:2: note: previous statement is here
    1222 |         if (!qsfp->gpio_irq[GPIO_INTL])
         |         ^
   1 warning generated.


vim +/if +1229 drivers/net/phy/qsfp.c

  1215	
  1216		if (qsfp->sm_dev_state == SFP_DEV_DETACHED) {
  1217			qsfp_sm_ins_next(qsfp, SFP_MOD_WATTACH, 0);
  1218			return;
  1219		}
  1220	
  1221		// Start the poller if there is no interrupt support if not running
  1222		if (!qsfp->gpio_irq[GPIO_INTL])
  1223			queue_delayed_work(system_wq, &qsfp->poll, poll_jiffies);
  1224	
  1225	//	ret = sfp_module_insert(qsfp->sfp_bus, &id);
  1226	//	if (ret < 0)
  1227	//		qsfp_sm_ins_next(qsfp, SFP_MOD_ERROR, 0);
  1228	//	else
> 1229			qsfp_sm_ins_next(qsfp, SFP_MOD_PRESENT, 0);
  1230	}
  1231	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



More information about the linux-arm-kernel mailing list