[PATCH] firmware: arm_scmi: Remove inappropriate error log.

sean yang seanyang230 at gmail.com
Thu Nov 2 04:42:29 PDT 2023


Hi,

Cristian Marussi <cristian.marussi at arm.com> 于2023年11月2日周四 19:25写道:
>
> On Wed, Nov 01, 2023 at 04:17:26PM +0800, xinglong.yang wrote:
> > The platform may not support fastchannel, but this is a legal
> > operation.
> >
> >         -Before this patch, when the platform not support fastchannel,
> >         goto err_xfer will print "Failed to ...". This log is misleading.
> >
> >         -With this patch, when the fastchannel is not been supported,
> >         the "Failed to ..." log will be skipped.
> >
>
> Hi,
>
> the message that you are killing:
>
>  dev_warn(ph->dev,
>           "Failed to get FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n",
>
> despite not being an error indeed, informs the user that some FCs could not be
> configured and we will revet to use full messaging...it can help detect an
> anomaly IMO.
>
> So I would NOT kill it at all and just drop this patch and instead change the
> dev_warn to dev_info and used a different wording instead of "Failed..." like
Thanks for your advice.
>
>           "Cannot configure FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n",
>
> Thanks,
> Cristian

Regards,
Xinglong



More information about the linux-arm-kernel mailing list