[PATCH] firmware: arm_scmi: Remove inappropriate error log.

xinglong.yang seanyang230 at gmail.com
Wed Nov 1 01:10:35 PDT 2023


The platform may not support fastchannel, but this is a legal
operation.

        -Before this patch, when the platform not support fastchannel,
        goto err_xfer  will print "Failed to ...". This log is misleading.

        -With this patch, when the fastchannel is not been supported,
        the "Failed to ..." log will be skipped.

Signed-off-by: xinglong.yang <xinglong.yang at cixtech.com>
---
 drivers/firmware/arm_scmi/driver.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index b5957cc12fee..2b990e50c8a5 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph,
 	 * fastchannels at all.
 	 */
 	ret = ph->xops->do_xfer(ph, t);
-	if (ret)
+	if (ret == -EOPNOTSUPP) {
+		ph->xops->xfer_put(ph, t);
+		goto return_normal;
+	} else if (ret)
 		goto err_xfer;
 
 	resp = t->rx.buf;
@@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph,
 		"Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n",
 		pi->proto->id, message_id, domain);
 
+return_normal:
 	return;
 
 err_db_mem:
-- 
2.42.0




More information about the linux-arm-kernel mailing list