[PATCH 1/8] clk: vc5: check memory returned by kasprintf()
Luca Ceresoli
luca.ceresoli at bootlin.com
Wed May 31 09:32:56 PDT 2023
Hi Claudiu,
On Tue, 30 May 2023 12:39:06 +0300
Claudiu Beznea <claudiu.beznea at microchip.com> wrote:
> kasprintf() returns a pointer to dynamically allocated memory.
> Pointer could be NULL in case allocation fails. Check pointer validity.
> Identified with coccinelle (kmerr.cocci script).
>
> Fixes: f491276a5168 ("clk: vc5: Allow Versaclock driver to support multiple instances")
> Signed-off-by: Claudiu Beznea <claudiu.beznea at microchip.com>
I think this driver would benefit a bit of refactoring, moving all
those similar sections to a single function.
But for the time being your change is fine:
Reviewed-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the linux-arm-kernel
mailing list