Aw: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3

[Frank Wunderlich]

> Gesendet: Dienstag, 07. Februar 2023 um 17:17 Uhr
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>
> Il 06/02/23 21:20, Matthias Brugger ha scritto:
> > 
> > 
> > On 05/02/2023 18:48, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <frank-w at public-files.de>
> >>
> >> Leds for Wifi are low-active, so add property to devicetree.
> >>
> >> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> >> ---
> >>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts 
> >> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> index 33bd6febc160..2b028141f1f7 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> @@ -446,5 +446,9 @@ &wifi {
> >>       pinctrl-names = "default", "dbdc";
> >>       pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> >>       pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> >> +
> >> +    led {
> >> +        led-active-low;
> >> +    };
> > 
> > The binding is missing this property also the driver implements it. Could you 
> > please update the bindind description properly?
> > Thanks
> > Matthias
> 
> 
> After and only after [1] is picked,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> 
> [1]: 
> https://patchwork.kernel.org/project/linux-mediatek/patch/20230207133504.21826-1-linux@fw-web.de/

Hi Matthias,

Can you take this patch into your tree? binding is already merged

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml#n114

regards Frank