[PATCH v3] net: stmmac: compare p->des0 and p->des1 with __le32 type values
Min-Hua Chen
minhuadotchen at gmail.com
Fri May 19 04:50:28 PDT 2023
Use cpu_to_le32 to convert the constants to __le32 type
before comparing them with p->des0 and p->des1 (they are __le32 type)
and to fix following sparse warnings:
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:23: sparse: warning: restricted __le32 degrades to integer
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:50: sparse: warning: restricted __le32 degrades to integer
Reviewed-by: Simon Horman <simon.horman at corigine.com>
Signed-off-by: Min-Hua Chen <minhuadotchen at gmail.com>
---
Change since v1:
use cpu_to_le32 to the constants
Change since v2:
remove unnecessary parentheses
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
index 13c347ee8be9..ffe4a41ffcde 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
@@ -107,7 +107,8 @@ static int dwxgmac2_rx_check_timestamp(void *desc)
ts_valid = !(rdes3 & XGMAC_RDES3_TSD) && (rdes3 & XGMAC_RDES3_TSA);
if (likely(desc_valid && ts_valid)) {
- if ((p->des0 == 0xffffffff) && (p->des1 == 0xffffffff))
+ if (p->des0 == cpu_to_le32(0xffffffff) &&
+ p->des1 == cpu_to_le32(0xffffffff))
return -EINVAL;
return 0;
}
--
2.34.1
More information about the linux-arm-kernel
mailing list