[PATCH] coresight: etm4x: Make etm4_remove_dev() return void

[Anshuman Khandual]

On 5/19/23 01:46, Uwe Kleine-König wrote:
> etm4_remove_dev() returned zero unconditionally. Make it return void
> instead, which makes it clear in the callers that there is no error to
> handle. Simplify etm4_remove_platform_dev() accordingly.

Agreed, as is the case in etm4_remove_amba().

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/hwtracing/coresight/coresight-etm4x-core.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 4c15fae534f3..3220c26f5dc2 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -2190,7 +2190,7 @@ static void clear_etmdrvdata(void *info)
>  	per_cpu(delayed_probe, cpu) = NULL;
>  }
>  
> -static int __exit etm4_remove_dev(struct etmv4_drvdata *drvdata)
> +static void __exit etm4_remove_dev(struct etmv4_drvdata *drvdata)
>  {
>  	bool had_delayed_probe;
>  	/*
> @@ -2217,8 +2217,6 @@ static int __exit etm4_remove_dev(struct etmv4_drvdata *drvdata)
>  		cscfg_unregister_csdev(drvdata->csdev);
>  		coresight_unregister(drvdata->csdev);
>  	}
> -
> -	return 0;
>  }
>  
>  static void __exit etm4_remove_amba(struct amba_device *adev)
> @@ -2231,13 +2229,12 @@ static void __exit etm4_remove_amba(struct amba_device *adev)
>  
>  static int __exit etm4_remove_platform_dev(struct platform_device *pdev)
>  {
> -	int ret = 0;
>  	struct etmv4_drvdata *drvdata = dev_get_drvdata(&pdev->dev);
>  
>  	if (drvdata)
> -		ret = etm4_remove_dev(drvdata);
> +		etm4_remove_dev(drvdata);
>  	pm_runtime_disable(&pdev->dev);
> -	return ret;
> +	return 0;
>  }

Makes sense.

Reviewed-by: Anshuman Khandual <anshuman.khandual at arm.com>

>  
>  static const struct amba_id etm4_ids[] = {
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b