[PATCH 18/53] drm/exynos: Convert to platform remove callback returning void

[대인기]

Hi,

> -----Original Message-----
> From: dri-devel <dri-devel-bounces at lists.freedesktop.org> On Behalf Of Uwe
> Kleine-Konig
> Sent: Monday, May 15, 2023 6:16 PM
> To: Inki Dae <daeinki at gmail.com>
> Cc: linux-samsung-soc at vger.kernel.org; Jingoo Han <jingoohan1 at gmail.com>;
> Seung-Woo Kim <sw0312.kim at samsung.com>; Kyungmin Park
> <kyungmin.park at samsung.com>; dri-devel at lists.freedesktop.org; Krzysztof
> Kozlowski <krzysztof.kozlowski at linaro.org>; kernel at pengutronix.de; Alim
> Akhtar <alim.akhtar at samsung.com>; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH 18/53] drm/exynos: Convert to platform remove callback
> returning void
> 
> On Mon, May 15, 2023 at 04:32:00PM +0900, Inki Dae wrote:
> > Hi,
> >
> > 2023년 5월 8일 (월) 오전 1:27, Uwe Kleine-König <u.kleine-
> koenig at pengutronix.de>님이 작성:
> > >
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is (mostly) ignored
> > > and this typically results in resource leaks. To improve here there is a
> > > quest to make the remove callback return void. In the first step of this
> > > quest all drivers are converted to .remove_new() which already returns
> > > void.
> > >
> > > Trivially convert the exynos drm drivers from always returning zero in
> > > the remove callback to the void returning variant.
> >
> > Could you please update exynos_drm_vidi.c also? Seems you missed.
> 
> This one cannot be trivially converted as vidi_remove() doensn't return
> zero in all cases. I didn't grok the details about ctx->raw_edid and
> don't know if skipping component_del() is right or not.
> 
> If you know the driver, feel free to address this.

I just posted one patch[1] which drops error return line from vidi_remove() because it's not an error case so it shouldn't return an error.
If you subscribed dri-devel then the patch must be in your mail box. On top of this, you could update it.

[1] [PATCH] drm/exynos: vidi: fix a wrong error return

Thanks,
Inki Dae

> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 |
> https://protect2.fireeye.com/v1/url?k=fb0b309c-9a709a0b-fb0abbd3-
> 74fe4860001d-c8cb2d724d092dbd&q=1&e=7188ced8-eb65-487a-8ba9-
> 420177df6b75&u=https%3A%2F%2Fwww.pengutronix.de%2F |