[PATCH 64/97] usb: ohci-at91: Convert to platform remove callback returning void

[Claudiu.Beznea at microchip.com]

On 18.05.2023 02:02, Uwe Kleine-König wrote:
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>


> ---
>  drivers/usb/host/ohci-at91.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 533537ef3c21..b9ce8d80f20b 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -599,7 +599,7 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
>         return usb_hcd_at91_probe(&ohci_at91_hc_driver, pdev);
>  }
> 
> -static int ohci_hcd_at91_drv_remove(struct platform_device *pdev)
> +static void ohci_hcd_at91_drv_remove(struct platform_device *pdev)
>  {
>         struct at91_usbh_data   *pdata = dev_get_platdata(&pdev->dev);
>         int                     i;
> @@ -611,7 +611,6 @@ static int ohci_hcd_at91_drv_remove(struct platform_device *pdev)
> 
>         device_init_wakeup(&pdev->dev, 0);
>         usb_hcd_at91_remove(platform_get_drvdata(pdev), pdev);
> -       return 0;
>  }
> 
>  static int __maybe_unused
> @@ -683,7 +682,7 @@ static SIMPLE_DEV_PM_OPS(ohci_hcd_at91_pm_ops, ohci_hcd_at91_drv_suspend,
> 
>  static struct platform_driver ohci_hcd_at91_driver = {
>         .probe          = ohci_hcd_at91_drv_probe,
> -       .remove         = ohci_hcd_at91_drv_remove,
> +       .remove_new     = ohci_hcd_at91_drv_remove,
>         .shutdown       = usb_hcd_platform_shutdown,
>         .driver         = {
>                 .name   = "at91_ohci",
> --
> 2.39.2
>