[PATCH 1/2] serial: stm32: Ignore return value of uart_remove_one_port() in .remove()

[Jiri Slaby]

On 12. 05. 23, 19:38, Uwe Kleine-König wrote:
> Returning early from stm32_usart_serial_remove() results in a resource
> leak as several cleanup functions are not called. The driver core ignores
> the return value and there is no possibility to clean up later.
> 
> uart_remove_one_port() only returns non-zero if there is some
> inconsistency (i.e. stm32_usart_driver.state[port->line].uart_port == NULL).
> This should never happen, and even if it does it's a bad idea to exit
> early in the remove callback without cleaning up.
> 
> This prepares changing the prototype of struct platform_driver::remove to
> return void. See commit 5c5a7680e67b ("platform: Provide a remove callback
> that returns no value") for further details about this quest.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Jiri Slaby <jirislaby at kernel.org>

thanks,
-- 
js
suse labs