[PATCH 2/2] serial: Make uart_remove_one_port() return void

Jiri Slaby jirislaby at kernel.org
Wed May 17 22:46:23 PDT 2023


On 12. 05. 23, 19:38, Uwe Kleine-König wrote:
> The return value is only ever used as a return value for remove callbacks
> of platform drivers. This return value is ignored by the driver core.
> (The only effect is an error message, but uart_remove_one_port() already
> emitted one in this case.)
> 
> So the return value isn't used at all and uart_remove_one_port() can be
> changed to return void without any loss. Also this better matches the
> Linux device model as remove functions are not supposed to fail.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Jiri Slaby <jirislaby at kernel.org>

thanks,
-- 
js
suse labs




More information about the linux-arm-kernel mailing list