[PATCH] misc/xilinx_sdfec: remove redundant _{open, release} function

Michal Simek michal.simek at amd.com
Mon May 15 02:33:20 PDT 2023



On 4/22/23 21:59, Bo Svangård wrote:
> 
> The functions are redundant as they are empty and performed by the misc
> driver.
> 
> Signed-off-by: Bo Svangård <bo.svangard at sylog.se>
> ---
>   drivers/misc/xilinx_sdfec.c | 12 ------------
>   1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index cb9506f9cbd0..270ff4c5971a 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -855,16 +855,6 @@ static int xsdfec_cfg_axi_streams(struct xsdfec_dev *xsdfec)
>          return 0;
>   }
> 
> -static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> -{
> -       return 0;
> -}
> -
> -static int xsdfec_dev_release(struct inode *iptr, struct file *fptr)
> -{
> -       return 0;
> -}
> -
>   static int xsdfec_start(struct xsdfec_dev *xsdfec)
>   {
>          u32 regread;
> @@ -1030,8 +1020,6 @@ static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
> 
>   static const struct file_operations xsdfec_fops = {
>          .owner = THIS_MODULE,
> -       .open = xsdfec_dev_open,
> -       .release = xsdfec_dev_release,
>          .unlocked_ioctl = xsdfec_dev_ioctl,
>          .poll = xsdfec_poll,
>          .compat_ioctl = compat_ptr_ioctl,
> --
> 2.40.0
> 

Acked-by: Michal Simek <michal.simek at amd.com>

Thanks,
Michal



More information about the linux-arm-kernel mailing list