[PATCH] ata: libata: Make ata_platform_remove_one return void

Serge Semin fancer.lancer at gmail.com
Sat May 13 14:00:21 PDT 2023


On Fri, May 12, 2023 at 10:46:46PM +0200, Uwe Kleine-König wrote:
> The function returned zero unconditionally, so the function returning an
> int is something between useless and irritating. With the goal to make
> platform drivers' remove function return void, it's helpful to convert
> the function accordingly. This converts several drivers to the new
> .remove_new callback that was introduced to smoothen the platform driver
> conversion.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---

[...]

>  drivers/ata/ahci_dwc.c         | 2 +-

[...]

> diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
> index 4bfbb09cdc02..9604a2f6ed48 100644
> --- a/drivers/ata/ahci_dwc.c
> +++ b/drivers/ata/ahci_dwc.c
> @@ -478,7 +478,7 @@ MODULE_DEVICE_TABLE(of, ahci_dwc_of_match);
>  
>  static struct platform_driver ahci_dwc_driver = {
>  	.probe = ahci_dwc_probe,
> -	.remove = ata_platform_remove_one,
> +	.remove_new = ata_platform_remove_one,
>  	.shutdown = ahci_platform_shutdown,
>  	.driver = {
>  		.name = DRV_NAME,

For DWC AHCI SATA
Acked-by: Serge Semin <fancer.lancer at gmail.com>

-Serge(y)

[...]

> -- 
> 2.39.2
> 



More information about the linux-arm-kernel mailing list