[PATCH 17/89] i2c: davinci: Convert to platform remove callback returning void

[Bartosz Golaszewski]

On Mon, May 8, 2023 at 10:53 PM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/i2c/busses/i2c-davinci.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 7ba7e6cbcc97..b77f9288c0de 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -885,7 +885,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>         return r;
>  }
>
> -static int davinci_i2c_remove(struct platform_device *pdev)
> +static void davinci_i2c_remove(struct platform_device *pdev)
>  {
>         struct davinci_i2c_dev *dev = platform_get_drvdata(pdev);
>         int ret;
> @@ -903,8 +903,6 @@ static int davinci_i2c_remove(struct platform_device *pdev)
>         pm_runtime_dont_use_autosuspend(dev->dev);
>         pm_runtime_put_sync(dev->dev);
>         pm_runtime_disable(dev->dev);
> -
> -       return 0;
>  }
>
>  #ifdef CONFIG_PM
> @@ -945,7 +943,7 @@ MODULE_ALIAS("platform:i2c_davinci");
>
>  static struct platform_driver davinci_i2c_driver = {
>         .probe          = davinci_i2c_probe,
> -       .remove         = davinci_i2c_remove,
> +       .remove_new     = davinci_i2c_remove,
>         .driver         = {
>                 .name   = "i2c_davinci",
>                 .pm     = davinci_i2c_pm_ops,
> --
> 2.39.2
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>