[RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML

[Jiri Pirko]

Thu, May 11, 2023 at 09:44:30AM CEST, arkadiusz.kubalewski at intel.com wrote:
>
>>From: Jiri Pirko <jiri at resnulli.us>
>>Sent: Friday, May 5, 2023 12:30 PM
>>
>>Thu, May 04, 2023 at 11:24:51PM CEST, kuba at kernel.org wrote:
>>>On Thu, 4 May 2023 14:02:30 +0200 Jiri Pirko wrote:
>>
>>[...]
>>
>>>
>>>> >+    name: device
>>>> >+    subset-of: dpll
>>>> >+    attributes:
>>>> >+      -
>>>> >+        name: id
>>>> >+        type: u32
>>>> >+        value: 2
>>>> >+      -
>>>> >+        name: dev-name
>>>> >+        type: string
>>>> >+      -
>>>> >+        name: bus-name
>>>> >+        type: string
>>>> >+      -
>>>> >+        name: mode
>>>> >+        type: u8
>>>> >+        enum: mode
>>>> >+      -
>>>> >+        name: mode-supported
>>>> >+        type: u8
>>>> >+        enum: mode
>>>> >+        multi-attr: true
>>>> >+      -
>>>> >+        name: lock-status
>>>> >+        type: u8
>>>> >+        enum: lock-status
>>>> >+      -
>>>> >+        name: temp
>>>> >+        type: s32
>>>> >+      -
>>>> >+        name: clock-id
>>>> >+        type: u64
>>>> >+      -
>>>> >+        name: type
>>>> >+        type: u8
>>>> >+        enum: type
>>>> >+      -
>>>> >+        name: pin-prio
>>>> >+        type: u32
>>>> >+        value: 19
>>>>
>>>> Do you still need to pass values for a subset? That is odd. Well, I
>>>> think is is odd to pass anything other than names in subset definition,
>>>> the rest of the info is in the original attribute set definition,
>>>> isn't it?
>>>> Jakub?
>>>
>>>Probably stale code, related bug was fixed in YNL a few months back.
>>>Explicit value should no longer be needed.
>>
>>What about the rest, like type, enum, multi-attr etc. Are they needed
>>for subset? If yes, why?
>>
>>
>
>It seems the name and type is needed. Without type generation scripts fails.
>For now fixed with having only name/type on subset attributes.

Okay. Jakub, any idea why "type" is needed here?


>
>Thanks!
>Arkadiusz