[PATCH 36/89] i2c: meson: Convert to platform remove callback returning void

Martin Blumenstingl martin.blumenstingl at googlemail.com
Wed May 10 13:41:08 PDT 2023


On Mon, May 8, 2023 at 10:53 PM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>



More information about the linux-arm-kernel mailing list