[PATCH 17/18] remoteproc: stm32: Convert to platform remove callback returning void

[Arnaud POULIQUEN]

Hi Uwe,

On 5/4/23 21:44, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen at foss.st.com>

Thanks,
Arnaud

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/remoteproc/stm32_rproc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 8746cbb1f168..19716ec82aae 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -867,7 +867,7 @@ static int stm32_rproc_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int stm32_rproc_remove(struct platform_device *pdev)
> +static void stm32_rproc_remove(struct platform_device *pdev)
>  {
>  	struct rproc *rproc = platform_get_drvdata(pdev);
>  	struct stm32_rproc *ddata = rproc->priv;
> @@ -885,8 +885,6 @@ static int stm32_rproc_remove(struct platform_device *pdev)
>  		device_init_wakeup(dev, false);
>  	}
>  	rproc_free(rproc);
> -
> -	return 0;
>  }
>  
>  static int __maybe_unused stm32_rproc_suspend(struct device *dev)
> @@ -916,7 +914,7 @@ static SIMPLE_DEV_PM_OPS(stm32_rproc_pm_ops,
>  
>  static struct platform_driver stm32_rproc_driver = {
>  	.probe = stm32_rproc_probe,
> -	.remove = stm32_rproc_remove,
> +	.remove_new = stm32_rproc_remove,
>  	.driver = {
>  		.name = "stm32-rproc",
>  		.pm = &stm32_rproc_pm_ops,