[PATCH] ARM: dts: aspeed: Add Supermicro X13dem system BMC devicetree

[Krzysztof Kozlowski]

On 09/05/2023 02:11, lesly895 at gmail.com wrote:
> From: Ryan Sie <ryans at supermicro.com.tw>
> 
> Add a devicetree for the new X13dem system.
> 
> Signed-off-by: Ryan Sie <ryans at supermicro.com.tw>
> ---
>  .../boot/dts/aspeed-bmc-supermicro-x13dem.dts | 283 ++++++++++++++++++
>  1 file changed, 283 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
> new file mode 100644
> index 000000000000..b5aac905e7ea
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
> @@ -0,0 +1,283 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2023 Supermicro Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/i2c/i2c.h>
> +
> +/ {
> +	model = "X13dem";

This does not look like full device name.

> +	compatible = "aspeed,ast2600";

Missing bindings.

> +
> +	aliases {
> +		mmc0 = &emmc;
> +	};
> +
> +	chosen {
> +		stdout-path = &uart5;
> +		bootargs = "console=ttyS4,115200n8 earlycon";

Drop bootags, not needed and not suitable to mainline wide use.

> +	};
> +
> +	memory at 80000000 {
> +		device_type = "memory";
> +		reg = <0x80000000 0x40000000>;
> +	};
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		/* LPC FW cycle bridge region requires natural alignment */
> +		flash_memory: region at b4000000 {
> +			no-map;
> +			reg = <0xb4000000 0x04000000>; /* 64M */
> +		};
> +
> +		/* VGA region is dictated by hardware strapping */
> +		vga_memory: region at bf000000 {
> +			no-map;
> +			compatible = "shared-dma-pool";
> +			reg = <0xbf000000 0x01000000>;  /* 16M */
> +		};
> +	};
> +
> +	leds {
> +	    compatible = "gpio-leds";
> +	    powerfail {

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

...

> +&rtc {
> +	status = "okay";
> +};
> +

Stray blank line

Best regards,
Krzysztof